Add command to move files with LSP support #8584

yo-main · 2023-10-21T21:07:46Z

Allows to rename the active buffer by moving it to another path.

:move my_new_file.rs

Heavily based on all the work done in #5531 by @ontley and apply the suggestions

The PR seems dead and I would really like to see that feature come into helix :)

archseer · 2023-10-22T10:59:21Z

Can you keep the commit history and retain the original author then? If the PR is simply rebased or patched up I'd like to retain the original author so we properly attribute the work they've put in.

ontley · 2023-10-22T11:11:26Z

Can you keep the commit history and retain the original author then? If the PR is simply rebased or patched up I'd like to retain the original author so we properly attribute the work they've put in.

It's a big change compared to the code I had, this adds multiple lsp server support and it handles it properly unlike mine

Co-authored-by: Pascal Kuthe <[email protected]>

helix-lsp/src/client.rs

helix-term/src/commands/typed.rs

yo-main · 2023-10-22T12:04:07Z

Can you keep the commit history and retain the original author then? If the PR is simply rebased or patched up I'd like to retain the original author so we properly attribute the work they've put in.

It's a big change compared to the code I had, this adds multiple lsp server support and it handles it properly unlike mine

Couldn't have manage the lsp thing without seeing how it was implemented in your PR :)
I managed to rebase my branch using your fork (that wasn't easy indeed 😄 I hope I didn't mess anything up)

helix-term/src/commands/typed.rs

pascalkuthe · 2023-10-24T20:33:23Z

this will probably need to wait for the next release, the current one is pretty close and I doubt we will merge new features before it

cbr9 · 2023-11-09T12:42:14Z

Shouldn't this command allow to move files into directories by automatically adding the filename? Currently you have to manually type the filename if you want to move the buffer into a directory

David-Else · 2023-11-11T09:45:37Z

I just tried this with ltex-ls and immediate problems :(

hx hello.md

(create some text and save)

:move bye.md

if you use move too fast (before the language server has finished working I assume) you get an error like:

2023-11-10T16:12:02.351 helix_lsp::transport [ERROR] ltex-ls err <- "WARNING: Could not find document with URI 'file:///home/david/Downloads/bye.md'\n"
2023-11-10T16:12:02.353 helix_lsp::transport [ERROR] marksman err <- "[16:12:02 WRN] <MarksmanServer> Document not found: {\"uri\": \"{ uri = \\\"file:///home/david/Downloads/bye.md\\\"\\n  data = AbsPath \\\"/home/david/Downloads/bye.md\\\" }\", \"method\": \"textDocumentDidChange\"}\n"
2023-11-10T16:12:02.460 helix_lsp::transport [ERROR] marksman err <- "[16:12:02 WRN] <MarksmanServer> Document not found: {\"uri\": \"{ uri = \\\"file:///home/david/Downloads/bye.md\\\"\\n  data = AbsPath \\\"/home/david/Downloads/bye.md\\\" }\", \"method\": \"textDocumentDidChange\"}\n"
2023-11-10T16:12:02.460 helix_lsp::transport [ERROR] ltex-ls err <- "Nov 10, 2023 4:12:02 PM org.bsplines.ltexls.server.LtexTextDocumentService getDocument\n"
2023-11-10T16:12:02.460 helix_lsp::transport [ERROR] ltex-ls err <- "WARNING: Could not find document with URI 'file:///home/david/Downloads/bye.md'\n"

If you wait for ltex-ls to fully load before moving then the new file then you get 'no code actions available' but the text seems to have inherited the old underline errors?

Anyway, something funny is going on with the language server in this case. I am running ltex-ls and marksman. Cheers.

pascalkuthe · 2023-11-11T10:01:59Z

That is a language server problem. What we do on our side is quite trivial

* Added rename command * Added an error if the new path already exists * Fixed wrong command name being used * fixed clippy suggestions * removed didRenameFiles call, fixed early return due to path Err * added ':rnm' alias to ':rename' * code cleanup * formatting * removed debug line * cargo fmt * Improved new buffer error message Co-authored-by: Pascal Kuthe <[email protected]> * Removed unnecessary path normalizing Co-authored-by: Pascal Kuthe <[email protected]> * Update helix-term/src/commands/typed.rs Co-authored-by: Pascal Kuthe <[email protected]> * Update helix-term/src/commands/typed.rs Co-authored-by: Pascal Kuthe <[email protected]> * Update helix-term/src/commands/typed.rs Co-authored-by: Pascal Kuthe <[email protected]> * Update helix-term/src/commands/typed.rs Co-authored-by: Pascal Kuthe <[email protected]> * feat: change `rename` command to `move` * feat: add multi lsp support when moving files * feat: allow lsp calls with a custom timeout * feat: sending lsp file_changed event once file has moved --------- Co-authored-by: ontley <[email protected]> Co-authored-by: ontley <[email protected]> Co-authored-by: Pascal Kuthe <[email protected]>

yo-main force-pushed the master branch 6 times, most recently from 7ffa81e to 88b3653 Compare October 22, 2023 09:03

ontley and others added 16 commits October 22, 2023 13:45

Added rename command

4a5dd70

Added an error if the new path already exists

c67822c

Fixed wrong command name being used

997d0eb

fixed clippy suggestions

721445a

removed didRenameFiles call, fixed early return due to path Err

5bf805f

added ':rnm' alias to ':rename'

4d6b78d

code cleanup

3c2fff1

formatting

f283a99

removed debug line

5bdbc95

cargo fmt

87ba9e1

Improved new buffer error message

18b0340

Co-authored-by: Pascal Kuthe <[email protected]>

Removed unnecessary path normalizing

03915e1

Co-authored-by: Pascal Kuthe <[email protected]>

Update helix-term/src/commands/typed.rs

0d7d380

Co-authored-by: Pascal Kuthe <[email protected]>

Update helix-term/src/commands/typed.rs

4967aae

Co-authored-by: Pascal Kuthe <[email protected]>

Update helix-term/src/commands/typed.rs

1142792

Co-authored-by: Pascal Kuthe <[email protected]>

Update helix-term/src/commands/typed.rs

073f130

Co-authored-by: Pascal Kuthe <[email protected]>

pascalkuthe requested changes Oct 22, 2023

View reviewed changes

yo-main force-pushed the master branch from 88b3653 to 12583db Compare October 22, 2023 12:01

feat: change rename command to move

7f47c01

yo-main force-pushed the master branch 2 times, most recently from 624977c to 5807113 Compare October 22, 2023 15:17

pascalkuthe reviewed Oct 22, 2023

View reviewed changes

helix-term/src/commands/typed.rs Outdated Show resolved Hide resolved

yo-main force-pushed the master branch from 41d4c48 to 08f8f0a Compare October 22, 2023 16:34

yo-main requested a review from pascalkuthe October 22, 2023 17:08

kirawi added A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer. labels Oct 23, 2023

ontley reviewed Oct 24, 2023

View reviewed changes

helix-term/src/commands/typed.rs Show resolved Hide resolved

yo-main requested a review from ontley October 24, 2023 19:34

pascalkuthe reviewed Oct 24, 2023

View reviewed changes

helix-term/src/commands/typed.rs Outdated Show resolved Hide resolved

yo-main force-pushed the master branch from f7032f4 to 9df6d48 Compare October 24, 2023 20:03

yo-main added 3 commits October 24, 2023 22:12

feat: add multi lsp support when moving files

a5d779f

feat: allow lsp calls with a custom timeout

f2b9572

feat: sending lsp file_changed event once file has moved

515aab4

yo-main force-pushed the master branch from 9df6d48 to 515aab4 Compare October 24, 2023 20:12

pascalkuthe approved these changes Oct 24, 2023

View reviewed changes

pascalkuthe added this to the next milestone Oct 24, 2023

ontley approved these changes Oct 25, 2023

View reviewed changes

This comment was marked as spam.

Sign in to view

the-mikedavis approved these changes Nov 8, 2023

View reviewed changes

the-mikedavis merged commit e868678 into helix-editor:master Nov 8, 2023
6 checks passed

the-mikedavis mentioned this pull request Nov 8, 2023

Add rename command. #4514

Closed

the-mikedavis mentioned this pull request Nov 29, 2023

LSP: Use workspace/willRenameFiles to handle rename resource operations #8942

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add command to move files with LSP support #8584

Add command to move files with LSP support #8584

yo-main commented Oct 21, 2023

archseer commented Oct 22, 2023

ontley commented Oct 22, 2023

yo-main commented Oct 22, 2023

pascalkuthe commented Oct 24, 2023

This comment was marked as spam.

cbr9 commented Nov 9, 2023

David-Else commented Nov 11, 2023

pascalkuthe commented Nov 11, 2023

Add command to move files with LSP support #8584

Add command to move files with LSP support #8584

Conversation

yo-main commented Oct 21, 2023

archseer commented Oct 22, 2023

ontley commented Oct 22, 2023

yo-main commented Oct 22, 2023

pascalkuthe commented Oct 24, 2023

This comment was marked as spam.

cbr9 commented Nov 9, 2023

David-Else commented Nov 11, 2023

pascalkuthe commented Nov 11, 2023